Changeset 171:af7a7f7a0e47 in finroc_plugins_data_ports

Timestamp:

06.02.2021 21:41:39 (3 years ago)

Author:

Max Reichardt <mreichardt@…>

Branch:

17.03

Children:

172:92474d0c642c, 173:2e0978d412b6

Phase:

public

Message:

Fixes compiler warnings that appear with additional non-default warning options enabled

Files:

• api/tGenericPortImplementation.cpp (modified) (1 diff)
• common/tAbstractDataPortCreationInfo.h (modified) (1 diff)
• optimized/cheaply_copied_types.cpp (modified) (1 diff)
• optimized/tSingleThreadedCheapCopyPortGeneric.cpp (modified) (1 diff)

api/tGenericPortImplementation.cpp

@@ -105 +105 @@
       port.CopyCurrentValueToGenericObject(*buffer.Get(), timestamp, strategy);
       buffer.SetTimestamp(timestamp);
-      return std::move(buffer);
+      return buffer;
     }
 #ifndef RRLIB_SINGLE_THREADED

common/tAbstractDataPortCreationInfo.h

@@ -211 +211 @@
     {}
 
-    tStorage(const tStorage& o)
+    tStorage(const tStorage& o) :
+      rrlib::serialization::tStackMemoryBuffer<INITIAL_SIZE>(5, true)
     {
       this->CopyFrom(o);

optimized/cheaply_copied_types.cpp

@@ -104 +104 @@
 {
   uint32_t result = (type.GetSize() <= cPOOL_BUFFER_SIZE_STEP) ? 0 : ((type.GetSize() - 1) / cPOOL_BUFFER_SIZE_STEP);
-  assert(result >= 0 && result < cMAX_SIZE_CHEAPLY_COPIED_TYPES / cPOOL_BUFFER_SIZE_STEP);
+  assert(result < cMAX_SIZE_CHEAPLY_COPIED_TYPES / cPOOL_BUFFER_SIZE_STEP);
   return result;
 }

optimized/tSingleThreadedCheapCopyPortGeneric.cpp

@@ -178 +178 @@
 bool tSingleThreadedCheapCopyPortGeneric::NonStandardAssign(tPublishingData& publishing_data, tChangeStatus change_constant)
 {
-  throw std::logic_error("Only implemented for/in subclasses");
+  assert(change_constant == tChangeStatus::NO_CHANGE && "Only implemented for/in subclasses");
+  return false;
 }