Changeset 70:c13cb74bba5c in finroc_plugins_network_transport

Timestamp:

06.02.2021 21:48:12 (8 months ago)

Author:

Max Reichardt <mreichardt@…>

Branch:

17.03

Children:

71:ed7a2222c5c4, 72:d0276f64c6d0

Phase:

public

Message:

Fixes compiler warnings that appear with additional non-default warning options enabled

Files:

• generic_protocol/tConnection.cpp (modified) (1 diff)
• generic_protocol/tRemoteRuntime.cpp (modified) (1 diff)
• runtime_info/tConnectorInfo.h (modified) (1 diff)
• runtime_info/tRemoteType.cpp (modified) (1 diff)

generic_protocol/tConnection.cpp

@@ -218 +218 @@
 void tConnection::ProcessPeerInfoMessage(rrlib::serialization::tMemoryBuffer& buffer)
 {
-  throw std::runtime_error("PEER_INFO OpCode not implemented in this network transport");
+  FINROC_LOG_PRINT(WARNING, "PEER_INFO OpCode not implemented in this network transport");
 }
 

generic_protocol/tRemoteRuntime.cpp

@@ -1012 +1012 @@
   rrlib::serialization::tOutputStream& stream = GetExpressConnection()->CurrentWriteStream();  // pull request is small -> we can always use express connection
   bool legacy = stream.GetTargetInfo().revision == 0;
-  uint8_t message_flags = legacy ? message_flags::cBINARY_ENCODING : pull_call_info.message_flags;
+  uint8_t message_flags = legacy ? static_cast<uint8_t>(message_flags::cBINARY_ENCODING) : pull_call_info.message_flags;
   tPullCall::Serialize(true, true, stream, legacy ? pull_call_info.remote_port_handle : pull_call_info.connection_handle, pull_call_info.call_id, message_flags);
   // Send immediately? (pull calls are somewhat outdated -> no); ex-code: this->SendPendingMessages(rrlib::time::Now(true));

runtime_info/tConnectorInfo.h

@@ -82 +82 @@
   } id;
 
-  friend inline rrlib::serialization::tOutputStream& operator << (rrlib::serialization::tOutputStream& stream, const tConnectorInfo::tID& info);
-
 
   struct tStaticInfo

runtime_info/tRemoteType.cpp

@@ -341 +341 @@
       break;
     case rrlib::rtti::tTypeClassification::NULL_TYPE:
+    default:
       break;
     }