Changeset 153:c2d7f2e0d112 in finroc_plugins_data_ports

Timestamp:

26.03.2020 15:34:59 (4 years ago)

Author:

Max Reichardt <max.reichardt@…>

Branch:

17.03

Phase:

public

Message:

Fixes minor issues tGenericPort: if DELETED/DO_NOT_CREATE_NOW flag is set, constructor no longer complains on missing data type. Furthermore, a tContructorParameters typedef is added which is required for use with convenience ports.

File:

• tGenericPort.h (modified) (2 diffs)

tGenericPort.h

@@ -88 +88 @@
 public:
 
+  /*! Bundles all possible constructor parameters of tPort */
+  typedef common::tAbstractDataPortCreationInfo tConstructorParameters;
+
   /*!
    * Empty constructor in case port is created later
@@ -110 +113 @@
   {
     tConstructorArguments<common::tAbstractDataPortCreationInfo> creation_info(arg1, arg2, args...);
-    if ((creation_info.data_type.GetTypeTraits() & rrlib::rtti::trait_flags::cIS_BINARY_SERIALIZABLE) == 0)
-    {
-      throw std::runtime_error("Only binary serializable types may be used in data ports");
-    }
     if (!creation_info.flags.Get(core::tFrameworkElementFlag::DELETED)) // do not create port, if deleted flag is set
     {
+      if ((creation_info.data_type.GetTypeTraits() & rrlib::rtti::trait_flags::cIS_BINARY_SERIALIZABLE) == 0)
+      {
+        throw std::runtime_error("Only binary serializable types may be used in data ports");
+      }
       implementation = api::tGenericPortImplementation::GetImplementation(creation_info.data_type);
       SetWrapped(implementation->CreatePort(creation_info));