Changeset 51:dd94eb0ccc61 in finroc_plugins_rpc_ports

Timestamp:

01.11.2021 10:04:59 (19 months ago)

Author:

Max Reichardt <mreichardt@…>

Branch:

17.03

Children:

52:79e3aca936e4, 53:0a3d0077cbfe

Phase:

public

Message:

Fixes several throw expressions - and moves them to .cpp files where appropriate

Location:

internal

Files:

• tAbstractCall.cpp (modified) (1 diff)
• tAbstractCall.h (modified) (1 diff)
• tRPCPort.cpp (modified) (1 diff)
• tRPCPort.h (modified) (1 diff)
• tRPCRequest.h (modified) (1 diff)
• tRPCResponse.h (modified) (1 diff)

internal/tAbstractCall.cpp

@@ -75 +75 @@
 {}
 
+void tAbstractCall::ReturnValue(rrlib::serialization::tInputStream& stream, tResponseSender& response_sender)
+{
+  throw std::runtime_error("This is a call without return value");
+}
+
 //----------------------------------------------------------------------
 // End of namespace declaration

internal/tAbstractCall.h

@@ -90 +90 @@
    * Deserializes/receives return value from stream
    */
-  virtual void ReturnValue(rrlib::serialization::tInputStream& stream, tResponseSender& response_sender)
-  {
-    throw new std::runtime_error("This is a call without return value");
-  }
+  virtual void ReturnValue(rrlib::serialization::tInputStream& stream, tResponseSender& response_sender);
 
   /*!

internal/tRPCPort.cpp

@@ -192 +192 @@
 }
 
+void tRPCPort::SendCall(tCallPointer && call_to_send)
+{
+  throw std::runtime_error("Not a network port");
+}
+
 //----------------------------------------------------------------------
 // End of namespace declaration

internal/tRPCPort.h

@@ -209 +209 @@
    * To be overridden by network port subclass
    */
-  virtual void SendCall(tCallPointer && call_to_send)
-  {
-    throw std::runtime_error("Not a network port");
-  }
+  virtual void SendCall(tCallPointer && call_to_send);
 };
 

internal/tRPCRequest.h

@@ -282 +282 @@
   static void DeserializeAndExecuteCallImplementation(rrlib::serialization::tInputStream& stream, tRPCPort& port, uint8_t function_id, tResponseSender& response_sender)
   {
-    throw new std::runtime_error("Not supported for functions returning void");
+    throw std::runtime_error("Not supported for functions returning void");
   }
 };

internal/tRPCResponse.h

@@ -326 +326 @@
       uint8_t function_id, tResponseSender& response_sender, tCallStorage* request)
   {
-    throw new std::runtime_error("Not supported for functions returning void");
+    throw std::runtime_error("Not supported for functions returning void");
   }
 };