Changeset 82:ef501464f31c in rrlib_design_patterns

Timestamp:

06.02.2021 21:13:33 (17 months ago)

Author:

Max Reichardt <mreichardt@…>

Branch:

17.03

Phase:

public

Message:

Fixes compiler warnings that appear with additional non-default warning options enabled

Location:

factory

Files:

• tCloneFactory.h (modified) (2 diffs)
• tFactory.h (modified) (2 diffs)

factory/tCloneFactory.h

@@ -81 +81 @@
   tTypeInfoWrapper(const TAbstractProduct &type) : type(typeid(type)) {}
   tTypeInfoWrapper(const TAbstractProduct *type) : type(typeid(*type)) {}
-  const bool operator < (const tTypeInfoWrapper &other) const
+  bool operator < (const tTypeInfoWrapper &other) const
   {
     return other.type.before(this->type);
@@ -112 +112 @@
 
   template <typename TProduct>
-  const bool Register(const tIdentifier &id)
+  bool Register(const tIdentifier &id)
   {
     return this->Register(id, &factory::DefaultCopyCloner<TProduct>);

factory/tFactory.h

@@ -86 +86 @@
   {};
 
-  const bool Register(const TIdentifier &id, const TProductCreator &product_creator)
+  bool Register(const TIdentifier &id, const TProductCreator &product_creator)
   {
     return this->id_to_creator_map.insert(std::make_pair(id, product_creator)).second;
@@ -92 +92 @@
 
   template <typename TProduct>
-  const bool Register(const TIdentifier &id)
+  bool Register(const TIdentifier &id)
   {
     return this->Register(id, factory::DefaultNewCreator<TProduct>());
   }
 
-  const bool Unregister(const TIdentifier &id)
+  bool Unregister(const TIdentifier &id)
   {
     return this->id_to_creator_map.erase(id) == 1;